gvSIG bugs #707

Mode filter to tables not working due a TODO pending change

Added by Ildefonso Junquero almost 14 years ago. Updated over 13 years ago.

Status:Closed% Done:

0%

Priority:NormalSpent time:-
Assignee:Juan Lucas Domínguez
Category:-
Target version:2.0.0-devel-2055
Severity: Add-on version:
gvSIG version:2.0.0 Add-on build:
gvSIG build:2046 Add-on resolve version:
Operative System: Add-on resolve build:
Keywords: Proyecto:
Has patch:No Hito:
Add-on name:Unknown

Description

In class WizardDB.java, there is a TODO comment:

// TODO: use the mode to filter tables with geometries when opening
// a view document
List parameters = dbExplorer.list();

That makes all tables in the scheme be available for the user to select.

A possible workaround for this would be:

int mode = DBServerExplorer.MODE_ALL;
            if (this instanceof WizardVectorialDB) {
                mode = DBServerExplorer.MODE_GEOMETRY;
            }
            List parameters = dbExplorer.list(mode);

I've made and tested the change and it works as I expected.

History

#1 Updated by María Maluenda over 13 years ago

  • Assignee set to Juan Lucas Domínguez

#2 Updated by María Maluenda over 13 years ago

  • Target version set to 2.0.0-rc1

#3 Updated by Juan Lucas Domínguez over 13 years ago

  • Status changed from New to Fixed

gvsig-desktop:r38920

List tables in DBServerExplorer.MODE_GEOMETRY mode when we deal with GeoDB layers

Added filter suggested by Ildefonso Junquero inside a little method which is overriden by subclass.

Test: Access a DB with geo data (PostGIS, Oracle Spatial) and check that only tables with geographic info are listed.

#4 Updated by Joaquín del Cerro Murciano over 13 years ago

  • Target version changed from 2.0.0-rc1 to 2.0.0-devel-2055

#5 Updated by Vicent Domenech over 13 years ago

  • Status changed from Fixed to Closed

Using gvSIG version 2056 (beta 1)

Also available in: Atom PDF