gvSIG bugs #505

Can't load WCS layers from Italian national geoportal in gvSIG 1.1x

Added by Antonio Falciano over 9 years ago. Updated almost 8 years ago.

Status:Fixed% Done:

100%

Priority:High
Assignee:Jorge Sanz
Category:-
Target version:-
Severity: Add-on name:Formats: WCS support (org.gvsig.raster.wcs.app.wcsclient)
gvSIG version:1.11.0 Add-on version:
gvSIG build: Add-on build:
Operative System:Windows Add-on resolve version:
Keywords: Add-on resolve build:
Has patch:No

Description

It's not possible to load WCS layers from the Italian national geoportal (GN/IDN). This is the WCS catalog: http://www.pcn.minambiente.it/PCNDYN/catalogowcs.jsp?lan=it
The WCS services are just been updated to version 1.1.2. The only version of gvSIG which is able to load these WCS layers is 1.1.2, without the need to request a lower version (&version=...).

notAliasedWCSurlPatch.txt Magnifier - Patch which solves the issue of not aliased WCS URLs (689 Bytes) Antonio Falciano, 07/31/2012 08:02 PM

History

#1 Updated by Antonio Falciano over 9 years ago

  • Status changed from New to Awaiting response
  • Target version set to 1.12.0-final

The issue still persists with gvSIG 1.12 RC1 (build 1413).
Here's an example of WCS layer taken from the Italian National Geoportal (GN/IDN):
URL: http://wms.pcn.minambiente.it/cgi-bin/mapserv.exe?map=/ms_ogc/wcs/dtm_75m.map
Capabilities: http://wms.pcn.minambiente.it/cgi-bin/mapserv.exe?map=/ms_ogc/wcs/dtm_75m.map&service=wcs&version=1.1.2&request=getCapabilities
This layer is load correctly only with gvSIG 1.1.2 (build 1045).
Cheers.

#2 Updated by Francisco Puga over 9 years ago

  • Status changed from Awaiting response to New
  • Target version deleted (1.12.0-final)

Hi,

I'm sorry but this issue also happen in gvSIG 1.11, so it can not be considered a regression, and it's not a critical error (data lost), so it can not be fixed right now, we are in the stabilization phase of the release.

Only regressions and critical bugs can be fixed.

I keep the issue open, but i remove the "target version"

#3 Updated by Antonio Falciano over 9 years ago

Hi Francisco,
building the extWCS and reading the debugging messages in the Eclipse console, I found that this issue is due to the incorrect parsing of WCS URL. In fact, if the URL to which I try to connect is the following:
http://wms.pcn.minambiente.it/cgi-bin/mapserv.exe?map=/ms_ogc/wcs/dtm_75m.map
then the Eclipse console reports:

31-lug-2012 13.03.17 org.gvsig.remoteClient.utils.Downloader run
INFO: downloading 'http://wms.pcn.minambiente.it/cgi-bin/mapserv.exe?REQUEST=DescribeCoverage&SERVICE=WCS&VERSION=1.0.0&EXCEPTIONS=XML' to: C:\Users\Antonio\AppData\Local\Temp\tmp-andami\wcs_describeCoverage1343732597015.xml
expected: START_TAG {null}CoverageDescription (position:START_TAG <HTML>@1:6 in java.io.InputStreamReader@134d246) 
org.xmlpull.v1.XmlPullParserException: expected: START_TAG {null}CoverageDescription (position:START_TAG <HTML>@1:6 in java.io.InputStreamReader@134d246) 
    at org.kxml2.io.KXmlParser.exception(Unknown Source)
[...]

There's an XmlPullParserException because the mapfile parameter (map=/ms_ogc/wcs/dtm_75m.map) is discarded during the parsing of this WCS URL without aliasing. So it seems not a big problem to solve...

#4 Updated by Antonio Falciano over 9 years ago

Hi Francisco(s),
I attach a simple patch for the WCSProtocolHandler class in libRemoteServices which solves the issue of not aliased WCS URLs (e.g. URLs containing the host and also some query parameters). I know that it's not a very elegant solution, because it bypasses the URL validation and so on, however it's how is exactly implemented in the WMSProtocolHandler. So can you evaluate to apply this patch in gvSIG 1.12 now? It would be a great addiction in gvSIG 1.12 for us in Italy (and not only), because it solves an issue which persists since gvSIG 1.9 and finally makes usable all the National Geoportal OGC web services! Thanks in advance for your kind attention. Cheers, Antonio

#5 Updated by Francisco José Peñarrubia over 9 years ago

  • Assignee set to Francisco Puga

+1
The change will affect only to the WCS, and if some exception is thrown, it will be catched later.

#6 Updated by Francisco Puga over 9 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r38627.

#7 Updated by Francisco Puga over 9 years ago

Antonio, i just notice myself that i not add a line to the commit message crediting you for the patch. Sorry. Usually i'm very careful with this kind of thinks, but i forgot do it, this time.

#8 Updated by Francisco Puga over 9 years ago

  • Target version set to 1.12.0-final

#9 Updated by Antonio Falciano over 9 years ago

Hi Francisco,
thanks for applying the patch and don't worry about the credits! ;)

#10 Updated by Jorge Sanz over 9 years ago

  • Status changed from Fixed to Awaiting response
  • Assignee changed from Francisco Puga to Jorge Sanz

Francisco Puga wrote:

Antonio, i just notice myself that i not add a line to the commit message crediting you for the patch. Sorry. Usually i'm very careful with this kind of thinks, but i forgot do it, this time.

Hi there,

first thank you very much for your contribution Antonio!

I just want to remind that the proper procedure before aplying any patch to the core of gvSIG projects the contributor has to sign the Contributor License Agreement. More info here and the English PDF here. Antonio you can send me directly the CLA by email or even attach it to this ticket if you want.

I know the patch is minimal but procedures are equal for everyone and have to be followed. Of course this procedure doesn't have to block anything as I guess there won't be any problem by your side so I will reopen this issue and reassign it to me until we have recorded the CLA.

Best regards
Jorge

#11 Updated by Antonio Falciano over 9 years ago

Jorge Sanz wrote:

I just want to remind that the proper procedure before aplying any patch to the core of gvSIG projects the contributor has to sign the Contributor License Agreement. More info here and the English PDF here. Antonio you can send me directly the CLA by email or even attach it to this ticket if you want.

I know the patch is minimal but procedures are equal for everyone and have to be followed. Of course this procedure doesn't have to block anything as I guess there won't be any problem by your side so I will reopen this issue and reassign it to me until we have recorded the CLA.

Hi Jorge,
you're right, I have just sent the signed CLA to you privately as you requested. Cheers.

#12 Updated by Jorge Sanz over 9 years ago

  • Status changed from Awaiting response to Fixed

I've received the CLA from Antonio so I'm closing this ticket.

Best
Jorge

#13 Updated by Álvaro Anguix almost 8 years ago

  • Project changed from Application: gvSIG desktop to | gvSIG desktop 1
  • Target version deleted (1.12.0-final)

Also available in: Atom PDF