gvSIG bugs #381

Reuse the cursors on postgis driver

Added by Francisco Puga about 12 years ago. Updated over 10 years ago.

Status:In progress% Done:

0%

Priority:Normal
Assignee:Francisco Puga
Category:-
Target version:-
Severity: Add-on name:Unknown
gvSIG version:1.12.0 Add-on version:
gvSIG build:1204 Add-on build:
Operative System: Add-on resolve version:
Keywords: Add-on resolve build:
Has patch:No

Description

Related to #278

gvSIG takes the features of a database layer in windows of 5000 elements. Each time it needs to get a new window it opens a new cursor (that is never close).

In r38040 i change this behaviour and now only one cursor is used.

There are still some issues with this bug:

  • The cursor is never close. We should study where to do it. It can be done on close(), but this method can be called so many times so it will penalize performance. If close the cursor here we must reopen it on the open() method and also make a check on setAbsolutePosition() to ensure that the cursor is declared.
  • The same cursor is used to draw the layer, draw the labels, and get the fields of the table. We should review how the layers are drawn because maybe this can be optimized using more than one cursor.

History

#1 Updated by Francisco Puga about 12 years ago

I mark it as 1.12 but i think that i will not have to time to look at this for 1.12, i think that this issue should be replanned

#2 Updated by Nacho Varela about 12 years ago

Hey! I think that a new sql query is executed in actions like "change color" or similar. Please, check it because avoid this kind of tasks can improve the performance very much.

#3 Updated by Francisco José Peñarrubia about 12 years ago

In PostgreSQL documentation, they say binary cursors will be closed when commit, or when session ends. Depending on WITH HOLD. (I didn't test it)

#4 Updated by Francisco Puga almost 12 years ago

  • Target version deleted (1.12.0-rc1)

#5 Updated by Álvaro Anguix over 10 years ago

  • Project changed from Application: gvSIG desktop to | gvSIG desktop 1

Also available in: Atom PDF