| gvSIG desktop 1

First of all: Fran, big kudos for this work! Although with some minor bugs, several users have let me know that this is an amazing feature. Now, let the battery of tests talk.

Imagine a layer structure in TOC like this:

• [1] layer
• [2] layer
• [3] layer
• [4] agrupation
  • [4.1] layer
  • [4.2] layer
  • [4.3] layer
• [5] layer
• [6] layer

Tests for moving layers:

1. Passes: move layer to intermediate positions (not top or bottom).
2. Passes: move agrupation to intermediate positions (not top or bottom).
3. Fails (sometimes): move single layer or agrupation to top or botton. For example, move layer [3] to first position (on layer [1]) or bottom position (under layer [6]): sometimes it fails and the red bar freezes waiting for the user and the log says "Invalid drop location".
4. Passes: move layer [2] within the agrupation [4].
5. Fails: move layer [2] within the agrupation [4], above layer [4.1]. The layer is added above layer [5].
6. Passes (but could be improved!): move layer [2] within the agrupation, below layer [4.3]. It works, but the red bar show no difference if the layer is going to be added inside the agrupation or outside (next test). What would be great is to make the red bar for this case shorter. If you just don't understand what I mean, please drop me a line :)
7. Passes: move layer [2] above agrupation [4] or below layer [5].

Tests for copy/paste layers:

1. Fails: copy/Paste layer. A contextual menu appears with two options ("paste on" or "paster under" the layer) and the menu doesn't dissapear when one of the options was selected although the layer was pasted. The layer is pasted, indeed. After talking with several users, the consensus about how it should be work is: don't show the contextual menu and choosing by default to paste the layer above the one selected or below the one selected and always do the same.

Other general comments:

• The patch works with several kind of layers. The tests were done including raster, vectorial and WMS layers, so there is no different behaviour between layers.
• It always keep the status of the layer (actived, deactivated) as it was. Thanks!
• When working with agrupations the performance is slower than with a single layer (ie: moving layers to agrupations, moving agrupations around, etc).
• Multiple selection fails. The tests were done with 1 item selected (layer or agrupation). Multiple selection (2 or more items) fails always, as only 1 of the items is moved. Although I see this very interesting, I don't see it prioritary.
• The color of the bar: would is be possible to choose a more neutral color? For example: a black or a obscure gray should work. Red color is a very agressive one and I prefer limit their use in interfaces to critical messages.

Fran, let me know if you need any help. I'm available to work on this.

Andres: A mi me funciona bien y tengo la extensión org.gvsig.crs activa.
Los otros dos problemas, creo que te los dejo para tí ;-) (pero si necesitas algo me avisas)

Saludos.

Fran.

Andrés Maneiro wrote:

• If having the extension org.gvsig.crs, copy/paste or cut/paste operations work but an error appears after the operation is done. The error doesn't happen if the extension CRS is removed from andami. Don't know if that's related to CRS or TOC actions. See log attached: copy_paste_with_crs_extension.txt

I think that is not related to TOC. It's a trouble with the native libproj.so.0.5.0 that is outdated. I think that is also related to #271. There is a bit mess with the mapcontrol, mapcontext, and i think that there are a lot of cases where is trying to reproyect a layer and is not needed.

Commited the changes for pasting layers to work in r38056. Please, review and close the bug if it fits the needs.